-
Notifications
You must be signed in to change notification settings - Fork 170
Chapter13 regions #280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Chapter13 regions #280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keboo
reviewed
Jun 27, 2022
src/Chapter13/Listing13.13.OmittingParameterTypesFromStatementLambdas.cs
Outdated
Show resolved
Hide resolved
Keboo
reviewed
Jun 27, 2022
Keboo
requested changes
Jun 27, 2022
Member
Keboo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to fix the compilation failures before completing
src/Chapter13/Listing13.12.CreatingDelegateWithStatementLambda.cs
Outdated
Show resolved
Hide resolved
BenjaminMichaelis
previously requested changes
Jun 27, 2022
src/Chapter13/Listing13.16.PassingADelegateWithAnExpressionLambda.cs
Outdated
Show resolved
Hide resolved
…lause.cs Co-authored-by: Benjamin Michaelis <benjamin@michaelis.net>
Member
|
@HannaMichaelis Were some of these comments intentionally resolved? I don't see the changes to fix them yet? |
Keboo
approved these changes
Jul 5, 2022
Keboo
approved these changes
Jul 5, 2022
Member
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Chapter 13 region corrections as well as confirming code excluding section 13.14
Contributes to Intellitect/EssentialCSharpManuscript#116